Use retarget defines where possible #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the condition code around the defines in mbed_retarget.h so all toolchains use the defined values. Exclude a small subset of values for GCC since these are in its standard header files.
|
/morph build |
Test : FAILUREBuild number : 358 |
Build : SUCCESSBuild number : 548 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 164 |
Test : SUCCESSBuild number : 359 |
0xc0170
approved these changes
Nov 20, 2017
|
Have you ran the incoming family tests over in the littlefs pr? They're probably the ones using these defines the most. If those pass I'm happy. |
theotherjimmy
added
release-version: 5.7.0-rc1
and removed
ready for merge
release-version: 5.6.6
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the condition code around the defines in mbed_retarget.h so all toolchains use the defined values. Exclude a small subset of values for GCC since these are in its standard header files.